Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1180 Split transaction Status for Transfers #1208

Merged
merged 2 commits into from
Jul 2, 2017

Conversation

stef145g
Copy link
Contributor

@stef145g stef145g commented Jul 1, 2017

This sets the status of a transfer as a 2 character token instead of one.
The database status is recorded as NN for both sides being unreconciled but is viewed as normal in Account View.
When the A side is reconciled and B side as Follow-up the database shows RF.
Viewing the transactions, the A side will show the status as R and viewing the B side will show as F

On changeover, both sides of a transaction will assume the current status for both sides until it is modified by the update. Reverting back and remodifying the transaction will restore to original.


This change is Reviewable

@slodki
Copy link
Contributor

slodki commented May 6, 2018

We shouldn't change dictionary changes to the database without db version change and existing entries update.
This breaks android app without warning.

@gabriele-v
Copy link
Contributor

Agree with @slodki
We should also provide a patch to set all previous transfers to RR, otherwise we will have some transfers with two characters and some with just one

@gabriele-v
Copy link
Contributor

I haven't seen this PR and noticed new behaviour before #1773 but it's a really big change that should be highlighted because it could also break custom reports looking at STATUS = "R"

@slodki slodki added the feature label Aug 21, 2018
@slodki slodki added this to the v1.4.0 milestone Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants