Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurring Transaction Check Fix #5244

Merged

Conversation

rguida
Copy link
Contributor

@rguida rguida commented Oct 28, 2022

This is a fix (plus a small improvement) of the Recurring Transaction Check.
Currently, the check is performed for all recurring transactions, regardless of whether they will be applied.
This results in an incorrect calculation in case the sum of all the transactions, even the ones that would not be immediately applied, would bring the balance below the minimum balance.

In short:

  • The check is now performed just before the transaction is applied.
  • The message box shows some details to help the user decide

Please do not forget to update the mmex.pot file and write information about the fixed bug in the prerelease page.


This change is Reviewable

- The check is now performed just before the transaction is applied.
- The message box shows some details to help the user decide
Copy link
Member

@whalley whalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the strings need to be enclosed in _( ) to signify that language translation applies.

@whalley whalley added this to the v1.6.1 milestone Oct 28, 2022
@whalley whalley added the bug label Oct 28, 2022
@rguida
Copy link
Contributor Author

rguida commented Oct 28, 2022

Looks good, but the strings need to be enclosed in _( ) to signify that language translation applies.

Done.
I changed my approach to minimise the number of strings to be translated.

@rguida rguida requested a review from whalley October 28, 2022 22:57
@whalley whalley merged commit 2fea6cc into moneymanagerex:master Oct 29, 2022
@whalley whalley added the fixed label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants