Change bson parsing to use mongo-query-parser #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dozoisch
force-pushed
the
change_document_parsing
branch
2 times, most recently
from
160b320
to
d8c9bda
Compare
JLLeitschuh
reviewed
Nov 11, 2019
| @@ -0,0 +1,19 @@ | |||
| diff --git a/node_modules/mongodb-query-parser/lib/index.js b/node_modules/mongodb-query-parser/lib/index.js | |||
There was a problem hiding this comment.
Did you intend to leave this file checked in?
There was a problem hiding this comment.
@JLLeitschuh yep, have to as query-parser was missing support for the $db parameter, and Timestamp was using the new bson format, while the dependency was still using the old format, so needed to make sure they were consistent.
I'll try to PR back the $db parameter in query-parser
mathieumg
reviewed
Nov 12, 2019
| var vm = require('vm'); | ||
| var json = require('./json'); | ||
| const parser = require('mongodb-query-parser'); | ||
| const ESJON = require('mongodb-extended-json'); |
There was a problem hiding this comment.
Unfortunately, can't update bson until mongodb-query-parser is updated to a more recent version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.