-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick dark mode hack #1960
Quick dark mode hack #1960
Conversation
How do we switch between the two modes? |
Chatted with @fredtruman about this. We thought we'd add a "toggle experimental dark mode" somewhere in the OS menu (e.g. under View) and set a global class we could use in some plugins to tweak some specific styling, e.g. the sidebar bg color. However, I just realized |
* Add compass shell plugin, bump compass home version * Bump compass-aggregations * Bump mongosh version to 0.0.2-alpha.0
…nto dark-mode-quick-win
Hi, it would be nice if someone can pick this up and finish it. Dark mode would be really great! |
Can't this be shipped as a plugin to toggle? I use darkreader all the time and I thought about this already in the past. Please add it to the official release so I can use it! You can add "(experimental)" to it or something. But it seams like a great compromise when not possible to ship a custom mode. This is the only app I have to run in light mode in my office, I have no idea why this was not a priority sooner. |
Is it too much to ask for? |
I forked the project and added darkreader package I don't know the codebase well so I just put the ipc handlers into index.js I used 1.28-release as a base branch, so I can build a stable app and use it for myself UPDATE!!! I created this PR #2444 |
Done in #2582. |
Description
Given that dark mode is being requested a lot, I was wondering if it could be hacked together quickly. I stumbled upon https://github.com/darkreader/darkreader and it turns out that if are willing to accept that the result won't be a perfect color palette, we can do dark mode with just a few lines of code.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes
Screenshots