fix(monorepo): Move release scripts back to compass package #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though this release script operates on the repo, it mostly touches files in the compass package. Instead of changing the filepaths in the script, it seems better to just keep it near compass source as the sole purpose of it is to release compass and nothing else
gribnoysup
commented
Apr 23, 2021
| "start": "lerna run start --stream --scope mongodb-compass", | ||
| "test": "lerna run test --stream", | ||
| "test-release-tasks": "cross-env MONGODB_DOWNLOADS_AWS_ACCESS_KEY_ID='' mocha --timeout 30000 release/*.spec.js" | ||
| "release": "cd packages/compass && npm run --silent release --", |
There was a problem hiding this comment.
Not doing this with lerna to prevent lerna from hijacking the stdio
gribnoysup
commented
Apr 23, 2021
gribnoysup
added a commit
that referenced
this pull request
Apr 23, 2021
* fix(monorepo): Move release scripts back to compass package Even though this release script operates on the repo, it mostly touches files in the compass package. Instead of changing the filepaths in the script, it seems better to just keep it near compass source as the sole purpose of it is to release compass and nothing else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though this release script operates on the repo, it mostly
touches files in the compass package. Instead of changing the
filepaths in the script, it seems better to just keep it near
compass source as the sole purpose of it is to release compass
and nothing else