chore(deps): bump driver/libmongocrypt to FLE2 versions #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this is hard to get to work with devtools-connect because it wants a non-prerelease peer dependency and |
addaleax
force-pushed
the
driver-fle2-alpha
branch
from
99b969a
to
5ee0397
Compare
Only use the 4.6.0-alpha.0 driver when the CSFLE feature flag is on.
addaleax
force-pushed
the
driver-fle2-alpha
branch
from
5ee0397
to
bd21fc0
Compare
Closed
gribnoysup
approved these changes
May 6, 2022
| @@ -50,6 +50,7 @@ export function createElectronMainConfig( | |||
| filename: opts.outputFilename ?? '[name].[contenthash].main.js', | |||
| assetModuleFilename: 'assets/[name].[hash][ext]', | |||
| strictModuleErrorHandling: true, | |||
| strictModuleExceptionHandling: true, | |||
There was a problem hiding this comment.
Based on what we found out (one option is deprecated in favor of another, but their behavior is different), let's maybe leave a comment here with a pointer to the code or something for the future
There was a problem hiding this comment.
Yeah, absolutely makes sense! 👍
Anemy
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only use the 4.6.0-alpha.0 driver when the CSFLE feature flag is on.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes