Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connection-form): add dynamic height to the form COMPASS-7895 #5792

Merged
merged 4 commits into from
May 22, 2024
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
115 changes: 81 additions & 34 deletions packages/connection-form/src/components/connection-form.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
import React, { useCallback, useMemo, useState } from 'react';
import React, {
useCallback,
useEffect,
useMemo,
useRef,
useState,
} from 'react';
import type {
ConnectionInfo,
ConnectionFavoriteOptions,
Expand Down Expand Up @@ -313,6 +319,41 @@ function ConnectionPersonalizationForm({
);
}

function useFormBodyStyles() {
const headerRef = useRef<HTMLDivElement>(null);
const footerRef = useRef<HTMLDivElement>(null);
const [styles, setStyles] = useState<React.CSSProperties>({
height: 'auto',
});

useEffect(() => {
const observer = new ResizeObserver(() => {
if (headerRef.current && footerRef.current) {
// 128 is the modal top/bottom margins, 45 is the modal body paddings
const height =
headerRef.current.clientHeight +
footerRef.current.clientHeight +
128 +
45;
setStyles({
height: `calc(100vh - ${height}px)`,
});
}
});

if (headerRef.current && footerRef.current) {
observer.observe(headerRef.current);
observer.observe(footerRef.current);
}

return () => {
observer.disconnect();
};
}, [headerRef, footerRef]);

return { headerRef, footerRef, styles };
}

export type ConnectionFormProps = ConnectionFormPropsWithoutPreferences & {
preferences?: Partial<ConnectionFormPreferences>;
};
Expand Down Expand Up @@ -454,6 +495,8 @@ function ConnectionForm({
'showFavoriteActions'
);

const { headerRef, footerRef, styles: formBodyStyles } = useFormBodyStyles();

return (
<ConfirmationModalArea>
<form
Expand All @@ -467,54 +510,57 @@ function ConnectionForm({
noValidate
>
<div className={formContainerStyles}>
<H3 className={formHeaderStyles}>
{initialConnectionInfo.favorite?.name ?? 'New Connection'}
<div ref={headerRef}>
<H3 className={formHeaderStyles}>
{initialConnectionInfo.favorite?.name ?? 'New Connection'}
{!isMultiConnectionEnabled && showFavoriteActions && (
<IconButton
type="button"
aria-label="Save Connection"
data-testid="edit-favorite-name-button"
className={editFavoriteButtonStyles}
onClick={() => {
setSaveConnectionModal('save');
}}
>
<Icon glyph="Edit" />
</IconButton>
)}
</H3>
<Description className={descriptionStyles}>
{!isMultiConnectionEnabled && 'Connect to a MongoDB deployment'}
{isMultiConnectionEnabled && 'Manage your connection settings'}
</Description>
{!isMultiConnectionEnabled && showFavoriteActions && (
<IconButton
type="button"
aria-label="Save Connection"
data-testid="edit-favorite-name-button"
className={editFavoriteButtonStyles}
data-testid="edit-favorite-icon-button"
type="button"
className={favoriteButtonStyles}
size="large"
onClick={() => {
setSaveConnectionModal('save');
}}
>
<Icon glyph="Edit" />
<div className={favoriteButtonContentStyles}>
<FavoriteIcon
isFavorite={!!initialConnectionInfo.favorite}
size={spacing[5]}
/>
<Overline className={favoriteButtonLabelStyles}>
FAVORITE
</Overline>
</div>
</IconButton>
)}
</H3>
<Description className={descriptionStyles}>
{!isMultiConnectionEnabled && 'Connect to a MongoDB deployment'}
{isMultiConnectionEnabled && 'Manage your connection settings'}
</Description>
{!isMultiConnectionEnabled && showFavoriteActions && (
<IconButton
aria-label="Save Connection"
data-testid="edit-favorite-icon-button"
type="button"
className={favoriteButtonStyles}
size="large"
onClick={() => {
setSaveConnectionModal('save');
}}
>
<div className={favoriteButtonContentStyles}>
<FavoriteIcon
isFavorite={!!initialConnectionInfo.favorite}
size={spacing[5]}
/>
<Overline className={favoriteButtonLabelStyles}>
FAVORITE
</Overline>
</div>
</IconButton>
)}
</div>
<div
className={
isMultiConnectionEnabled
? formContentStyles
: cx(formContentStyles, formContentLegacyStyles)
}
style={formBodyStyles}
>
<div className={formSettingsStyles}>
<ConnectionStringInput
Expand Down Expand Up @@ -554,6 +600,7 @@ function ConnectionForm({
</div>
</div>
<div
ref={footerRef}
className={
isMultiConnectionEnabled
? cx(
Expand Down
Loading