CRUD refactoring #691
CRUD refactoring #691
Conversation
pzrq
force-pushed
the
crud-refactor
branch
2 times, most recently
from
df78275
to
8b6b535
Compare
| } | ||
|
|
||
| // at this point compare the documents themselves and update if not different | ||
| return !_.isEqual(nextState.docs, this.state.docs); |
There was a problem hiding this comment.
This was probably more expensive than React's internal check - did you notice a speed improvement in the list once removing?
|
@durran Dug deeper and it was more that the check didn't seem to be doing anything that made Compass more or less responsive, i.e. there doesn't seem to be much value to this code apart from being a source of bugs in the past (this screenshot was from master, not
|
pzrq
force-pushed
the
crud-refactor
branch
2 times, most recently
from
968b3af
to
1f5d263
Compare
|
@durran If you know why these TravisCI timeouts are occurring, fixes welcome 👍 This refactoring is not currently blocking anything (I thought it might block COMPASS-541 but it ultimately turned out to be not required). I'll most likely wait until your presentation next Tuesday Jaguar time so we can all benefit from your knowledge writing and debugging these tests, i.e. happy to let these build logs stick around until we have a good understanding of their cause and resolution, or at least how to make the errors more deterministic. |
|
Build failure on master (https://travis-ci.com/10gen/compass/jobs/59828761, which I will restart momentarily) is very similar to https://travis-ci.com/10gen/compass/jobs/59723655
|
|
Note that the "element is not clickable" error is most likely caused by the status bar not finishing its progress and the transparent overlay is still over the entire screen. Another |
|
Yes, good to see Have rebased, hopefully we won't see any more Travis issues, but if we do we'll still learn something. |
It was used originally for minicharts/refine bar, see: c3c2e7a
_key() always returns a new uuid.v4()
Even React recommends against it: https://facebook.github.io/react/docs/react-component.html#shouldcomponentupdate I could find no detectable performance or snappiness difference between this version and the version before, using every local dataset I have excluding the perf.big and perf.medium ones (COMPASS-560), such as the mongodb.fanclub, enron.messages and blog.posts collections which are sluggish on initial load but fine afterwards, e.g. when inserting, editing, cloning or a document.
Appears to be completely replaced by the QueryStore in 'compass/src/internal-packages/query/lib/store/query-store.js'
|
Thanks @durran 👍 |
While in the area trying to understand how to resolve COMPASS-541, noticed these things I think can be safely removed, or typos fixed.