Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRUD refactoring #691

Merged
merged 5 commits into from
Dec 20, 2016
Merged

CRUD refactoring #691

merged 5 commits into from
Dec 20, 2016

Commits on Dec 19, 2016

  1. Drop volatileQueryOptions 

    It was used originally for minicharts/refine bar, see:
c3c2e7a
    @pzrq
    pzrq committed Dec 19, 2016
    Configuration menu
    Copy the full SHA
    506a01f View commit details
    Browse the repository at this point in the history

  2. Drop unused doc parameter 

    _key() always returns a new uuid.v4()
    @pzrq
    pzrq committed Dec 19, 2016
    Configuration menu
    Copy the full SHA
    8ec3e6d View commit details
    Browse the repository at this point in the history

  3. Typo: Boolean

    @pzrq
    pzrq committed Dec 19, 2016
    Configuration menu
    Copy the full SHA
    2c0f9f5 View commit details
    Browse the repository at this point in the history

  4. Drop premature optimisation 

    Even React recommends against it:
https://facebook.github.io/react/docs/react-component.html#shouldcomponentupdate

I could find no detectable performance or snappiness difference between this version and the version before, using every local dataset I have excluding the perf.big and perf.medium ones (COMPASS-560), such as the mongodb.fanclub, enron.messages and blog.posts collections which are sluggish on initial load but fine afterwards, e.g. when inserting, editing, cloning or a document.
    @pzrq
    pzrq committed Dec 19, 2016
    Configuration menu
    Copy the full SHA
    7f3f636 View commit details
    Browse the repository at this point in the history

  5. Drop queryOptions 

    Appears to be completely replaced by the QueryStore in 'compass/src/internal-packages/query/lib/store/query-store.js'
    @pzrq
    pzrq committed Dec 19, 2016
    Configuration menu
    Copy the full SHA
    3f1a394 View commit details
    Browse the repository at this point in the history