This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
Add support for Promises in module #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses `util.promisify` built into Node v8 to create a Promise from the
is-mongodb-running function.
These changes are backwards compatible with the current callback style
function. If the Promise-style function is desired, simple
require('is-mongodb-running/promise') to get the promisified function
instead.
Updated the is-mongodb-running binary to use promises. Code looks a bit
cleaner
|
cc: @imlucas Do you mind looking at these when you get a chance, please? |
|
Sweet! Apologies again for the delay and thanks so much @addisonElliott! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
util.promisifybuilt into Node v8 to create a Promise from theis-mongodb-running function.
These changes are backwards compatible with the current callback style
function. If the Promise-style function is desired, simple
require('is-mongodb-running/promise') to get the promisified function
instead.
Updated the is-mongodb-running binary to use promises. Code looks a bit
cleaner.
Travis CI errors are unrelated to the PR. Issues are fixed in #9.
Resolves issue #5.
Note: @imlucas What do you think about this method? It doesn't break compatibility and it allows the use of promises. Personally, I'm on the fence about this because the util.promisify function could be called upon importing the module. Thus, the question is whether it is something the library should support.