Skip to content
This repository has been archived by the owner on Dec 20, 2023. It is now read-only.

Fix windows support and fix Travis CI failure #9

Merged
merged 4 commits into from
Oct 10, 2018

Conversation

addisonElliott
Copy link
Contributor

Fix two issues in the repository:

  1. Fix eslint errors that cause Travis CI to fail. The error is a no-shadow issue with shadowing variables but this is not actually happening because the variables are defined in an if/else block so they will never shadow each other. Anyway, I fixed this by moving the declaration out of the if/else block
  2. Fix windows support but updating the command string to search for in ps.lookup.
    • Rather than searching only for mongod.exe in Windows, I search for mongod or mongod.exe because both are valid commands in Windows.
    • When using mongodb-runner start command in Windows, the ps.lookup command returns mongod and not mongod.exe. Therefore, it would incorrectly state no instances are running when one was.

This was referenced Aug 25, 2018
@addisonElliott
Copy link
Contributor Author

Bump.

@imlucas imlucas merged commit fc3c6e1 into mongodb-js:master Oct 10, 2018
@imlucas
Copy link
Contributor

imlucas commented Oct 10, 2018

Thanks @addisonElliott!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants