Skip to content

Commit

Permalink
fix: review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
wtrocki committed Mar 27, 2024
1 parent 12f3972 commit c61e96e
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 33 deletions.
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
golang 1.20
golang 1.22.1
nodejs 18.18.2

2 changes: 1 addition & 1 deletion examples/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module go.mongodb.org/atlas-sdk/v20231115008/examples

go 1.20
go 1.22.1

require (
github.com/go-test/deep v1.1.0
Expand Down
4 changes: 2 additions & 2 deletions examples/retry/retry.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ func main() {
retryClient := retryablehttp.NewClient()
retryClient.RetryMax = 3

retryableClient := createRetryableClient(retryClient, apiKey, apiSecret)
retryableClient := newRetryableClient(retryClient, apiKey, apiSecret)
sdk, err := admin.NewClient(
admin.UseHTTPClient(retryableClient),
admin.UseBaseURL(url),
Expand All @@ -59,7 +59,7 @@ func main() {

}

func createRetryableClient(retryClient *retryablehttp.Client, apiKey string, apiSecret string) *http.Client {
func newRetryableClient(retryClient *retryablehttp.Client, apiKey string, apiSecret string) *http.Client {
var transport http.RoundTripper = &retryablehttp.RoundTripper{Client: retryClient}
digestRetryAbleTransport := digest.NewTransportWithHTTPRoundTripper(apiKey, apiSecret,transport)
retryableClient, err := digestRetryAbleTransport.Client()
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module go.mongodb.org/atlas-sdk/v20231115008

go 1.20
go 1.22.1

require (
github.com/go-test/deep v1.1.0
Expand Down
28 changes: 0 additions & 28 deletions internal/main.go

This file was deleted.

0 comments on commit c61e96e

Please sign in to comment.