RUBY-1702 Skip creating Time instance in Date serialization #118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: RUBY-1702
I haven't found any nice solution for DateTimes - there is no way to get
df
attribute - which apparently holds second since beginning of day. I could use things likeoffset
/sec_fraction
etc., but this would be much harder to read + would actually create more instances (of Rational) than just usingto_time
as in current implementation.