RUBY-2810 Make as_json serializations user-friendly for numeric types #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- BSON::Decimal128 - BSON::Int32 - BSON::Int64 - BSON::Regexp - BSON::Timestamp
- Int32 and Int64 were missing JSON module
* master: Float: Refactor #as_extended_json to get rid of nested ifs (mongodb#244) RUBY-2783 Add BSON::Symbol::Raw#as_json and BSON::Undefined#as_json + test coverage mongodb#246 (mongodb#246) RUBY-2783 Return a String without "$oid" from BSON::ObjectId#as_json and #to_json (mongodb#241) Hash: Better implementation of #as_extended_json. Can use #transform_values since we're on Ruby 2.4+ (mongodb#243) Raise a friendlier load error when running specs (mongodb#239) Fix readme RUBY-2655 Fix GH actions (mongodb#240)
p-mongo
changed the title
|
Extracted from #242. |
comandeo
approved these changes
Oct 19, 2021
p-mongo
pushed a commit
to johnnyshields/bson-ruby
that referenced
this pull request
Oct 19, 2021
* master: Fix docstring (mongodb#248) RUBY-2810 Make as_json serializations user-friendly for numeric types (mongodb#249)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.com/browse/RUBY-2810