RUBY-3435 Don't overflow the 4-bytes allotted to an ObjectID's timestamp portion #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've run this in my test suite and confirmed that it fixes the bug. Thank you! |
comandeo-mongo
approved these changes
Apr 8, 2024
|
@jamis this is running in production for us now FYI 🎉 |
|
Wonderful, thanks for the confirmation, @johnnyshields. We'll get it officially released soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the timestamp is (1) treated as an unsigned integer, to allow the largest possible value there, and (2) truncated to 32 bits (4 bytes) if it ever grows larger than that. This avoids a RangeError that occurs when trying to convert a Bignum to a 32-bit integer internally.