Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-17414: ChangeStream paradim errors #201

Merged
merged 4 commits into from
Jul 9, 2021

Conversation

terakilobyte
Copy link
Member

@terakilobyte terakilobyte commented Jul 7, 2021

This changes the warning text to state that mixing paradigms will error. Upstream PR

Pull Request Info

Issue JIRA link:

https://jira.mongodb.org/browse/DOCSP-17414

Docs staging link (requires sign-in on MongoDB Corp SSO):

https://docs-mongodbcom-staging.corp.mongodb.com/node/docsworker-xlarge/DOCSP-17414/usage-examples/changeStream/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Does it render on staging correctly?
  • Are all the links working?
  • Are the staging links in the PR description updated?

This changes the warning text to state that mixing paradigms will error.
Copy link
Contributor

@ccho-mongodb ccho-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Messaging looks good, but let's make sure we adhere to our writing guidelines.

source/includes/changestream-paradigm-warning.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@ccho-mongodb ccho-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A style issues, but otherwise LGTM!

source/includes/changestream-paradigm-warning.rst Outdated Show resolved Hide resolved
source/includes/changestream-paradigm-warning.rst Outdated Show resolved Hide resolved
@terakilobyte
Copy link
Member Author

@nbbeeken @emadum Does this capture change in behavior?

Copy link

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@terakilobyte terakilobyte merged commit 9cb6808 into mongodb:master Jul 9, 2021
@terakilobyte terakilobyte deleted the DOCSP-17414 branch August 23, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants