Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reword admonition #730

Merged
merged 1 commit into from
Aug 4, 2023
Merged

reword admonition #730

merged 1 commit into from
Aug 4, 2023

Conversation

mongoKart
Copy link
Collaborator

Pull Request Info

Reworded admonition in 5.4 per Chris's comment from this PR.. Will be backported back through 5.4

PR Reviewing Guidelines

Staging - https://docs-mongodbcom-staging.corp.mongodb.com/drivers/docsworker-xlarge/NNNNN/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

nickldp
nickldp approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@nickldp nickldp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mongoKart mongoKart merged commit 5344333 into mongodb:master Aug 4, 2023
1 check passed
@mongoKart mongoKart deleted the reword-admonition branch August 4, 2023 18:23
mongoKart added a commit that referenced this pull request Aug 4, 2023
@mongoKart
reword (#730)
5ac7b51 
(cherry picked from commit 5344333)
mongoKart added a commit that referenced this pull request Aug 4, 2023
@mongoKart
reword (#730)
3f480c2 
(cherry picked from commit 5344333)
mongoKart added a commit that referenced this pull request Aug 4, 2023
@mongoKart
reword (#730)
46091f8 
(cherry picked from commit 5344333)
mongoKart added a commit that referenced this pull request Aug 4, 2023
@mongoKart
reword (#730)
180f456 
(cherry picked from commit 5344333)
mongoKart added a commit to mongoKart/docs-node that referenced this pull request Nov 3, 2023
@mongoKart
reword (mongodb#730)
a73b5ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickldp nickldp nickldp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mongoKart @nickldp