Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

(DOCSP-7436): adding k8s-op-om-setting directive #331

Merged
merged 3 commits into from
Oct 23, 2019

Conversation

jwilliams-mongo
Copy link
Contributor

JIRA

adding new directive to work around issue with reusing :settings: with the same name on multiple pages

Copy link
Contributor

@jdestefano-mongo jdestefano-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -331,6 +331,13 @@
'prepend': True,
'callable': False
},
{
'name': 'k8s-op-om-setting',
Copy link
Contributor

@kay-kim kay-kim Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jwilliams-mongo , @jdestefano-mongo -- this is rather a mouthful of a name and tag. I think for usability, you all might want to shorten this.

.. _k8s-op-om-setting:: foobar

then to link :k8s-op-om-setting:`foobar` . which I can see as inviting typos and forgetting what the setting name was.

Also, for some references, you will have to prepend the tag so that people will have to do :k8s-op-om-setting:`~k8s-op-om-setting.foobar`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point @kay-kim. made these shorter. look good to you?

@@ -332,8 +332,8 @@
'callable': False
},
{
'name': 'k8s-op-om-setting',
'tag': 'k8s-op-om-setting',
'name': 'omk8sop',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about

  • opsmgrkube or
  • opsmgrk8s or

The reason I kind of prefer kube is so that when typing you don't have to reach for the number. but I don't actually care as I won't need to use this settings, but definitely think about typing/usability.

@kay-kim kay-kim merged commit 308097d into mongodb:master Oct 23, 2019
@kay-kim
Copy link
Contributor

kay-kim commented Oct 23, 2019

merged!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants