DOP-4474: redirects for offline part 1 #1041
Conversation
|
Your feature branch infrastructure has been deployed! Your webhook URL is: https://og4qr0ym8a.execute-api.us-east-2.amazonaws.com/prod/webhook/githubEndpoint/trigger/build For more information on how to use this endpoint, follow these instructions. |
| - RoutingRuleCondition: | ||
| KeyPrefixEquals: ${self:custom.site.prefix.${self:provider.stage}}/atlas/cli/v1.2.1 | ||
| KeyPrefixEquals: ${self:custom.site.prefix.${self:provider.stage}}/atlas/cli/v1.2 | ||
| RedirectRule: | ||
| Protocol: "https" | ||
| HostName: ${self:custom.site.host.${self:provider.stage}} | ||
| ReplaceKeyPrefixWith: ${self:custom.site.prefix.${self:provider.stage}}/atlas/cli/v1.2 | ||
| - RoutingRuleCondition: | ||
| KeyPrefixEquals: ${self:custom.site.prefix.${self:provider.stage}}/atlas/cli/v1.2.0 | ||
| KeyPrefixEquals: ${self:custom.site.prefix.${self:provider.stage}}/atlas/cli/v1.1 | ||
| RedirectRule: | ||
| Protocol: "https" | ||
| HostName: ${self:custom.site.host.${self:provider.stage}} | ||
| ReplaceKeyPrefixWith: ${self:custom.site.prefix.${self:provider.stage}}/atlas/cli/v1.2 | ||
| ReplaceKeyPrefixWith: ${self:custom.site.prefix.${self:provider.stage}}/atlas/cli/v1.1 |
There was a problem hiding this comment.
a little confused on these changes - won't this redirect /v1.2 to itself and same with v1.1?
There was a problem hiding this comment.
Yes, but it'll also capture v1.2.x and v1.21 and replace them with v1.2, which is the outcome we want (same with v1.1*)
infrastructure/ecs-main/buckets.yml
Outdated
| HostName: ${self.custom.site.host.${self:provider.stage}} | ||
| ReplaceKeyPrefixWith: ${self:custom.site.prefix.${self:provider.stage}}/kubernetes-operator/stable | ||
| - RoutingRuleCondition: | ||
| KeyPrefixEquals: ${self:custom.site.prefix.${self:provider.stage}}/kubernetes-operator/v1.1 |
There was a problem hiding this comment.
do we also need to add rules for k8s v1.2 through v1.9? i see those on the spreadsheet but (unless i'm not looking correctly) i don't see those here!
There was a problem hiding this comment.
Ooh good catch, it should just be v1 -- fixing.
infrastructure/ecs-main/buckets.yml
Outdated
| HostName: ${self.custom.site.host.${self:provider.stage}} | ||
| ReplaceKeyPrefixWith: ${self:custom.site.prefix.${self:provider.stage}}/kubernetes-operator/stable | ||
| - RoutingRuleCondition: | ||
| KeyPrefixEquals: ${self:custom.site.prefix.${self:provider.stage}}/mongocli/v0 |
There was a problem hiding this comment.
(tiny micro nit) perhaps make this v0. for consistency with the v0. above?
| RedirectRule: | ||
| Protocol: "https" | ||
| HostName: ${self.custom.site.host.${self:provider.stage}} | ||
| ReplaceKeyPrefixWith: ${self:custom.site.prefix.${self:provider.stage}}/mongocli/stable |
There was a problem hiding this comment.
again, unless I'm not looking correctly, I don't see redirects for mongo cli v1.0.0-1.24
There was a problem hiding this comment.
mongocli v1.0.0-v1.24 build with Snooty, so we don't have offline versions of them currently! Marvellous attention to detail though :)
| HostName: ${self.custom.site.host.${self:provider.stage}} | ||
| ReplaceKeyPrefixWith: ${self:custom.site.prefix.${self:provider.stage}}/kubernetes-operator/stable | ||
| - RoutingRuleCondition: | ||
| KeyPrefixEquals: ${self:custom.site.prefix.${self:provider.stage}}/kubernetes-operator/v1.0 |
There was a problem hiding this comment.
can probaby remove this rule, since we have the /v1 prefix now
Stories/Links:
DOP-4474
Notes
README updates