CLOUDP-67056: Implement search API in the go client #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robcarlan-mlab
previously approved these changes
Jul 14, 2020
|
@themantissa ready for you |
themantissa
previously approved these changes
Jul 14, 2020
| CreateIndex(context.Context, string, string, *SearchIndex) (*SearchIndex, *Response, error) | ||
| UpdateIndex(context.Context, string, string, string, *SearchIndex) (*SearchIndex, *Response, error) | ||
| DeleteIndex(context.Context, string, string, string) (*Response, error) | ||
| ListAnalyzers(context.Context, string, string, *ListOptions) ([]*SearchAnalyzer, *Response, error) |
There was a problem hiding this comment.
Curious if leaving Update Analyzers out was intentional? (https://docs.atlas.mongodb.com/reference/api/fts-analyzers-update-all/)
There was a problem hiding this comment.
Somewhat intentional, there are plans to deprecate Custom Analyzers so I'm trying to limit us to only read them (if ever needed)
PacoDw
suggested changes
Jul 15, 2020
gssbzn
dismissed stale reviews from PacoDw, themantissa, and robcarlan-mlab
via
0c71afa
robcarlan-mlab
approved these changes
Jul 15, 2020
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add search support
Type of change:
Required Checklist:
make fmtand formatted my code