Skip to content

Conversation

@PacoDw
Copy link
Contributor

@PacoDw PacoDw commented Aug 10, 2020

Description

  • Updated changelog to v0.4.0
  • changed dates as the Terraform changelog to have more coherency

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit to add the enhancements more clearly. Then ready Ty!

@PacoDw PacoDw requested a review from themantissa August 12, 2020 17:01
@themantissa themantissa requested a review from gssbzn August 12, 2020 22:27
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - added internal reviewer as a heads that we are cutting 0.4.0 (and as a last check since there are more dependencies now). Once @gssbzn approves feel free to proceed.

Also side note, a few small things just got merged that are not in this list. I'm not concerned with adding them as the PRs can be reviewed and none should have a huge impact.

Copy link
Contributor

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Copy link
Contributor

@coderGo93 coderGo93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PacoDw PacoDw merged commit a444b22 into master Aug 13, 2020
@PacoDw PacoDw deleted the changelog_v0.4.0 branch August 13, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants