Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-139997: added OplogMinRetentionHours to ProcessArgs #316

Merged
merged 4 commits into from Oct 12, 2022
Merged

CLOUDP-139997: added OplogMinRetentionHours to ProcessArgs #316

merged 4 commits into from Oct 12, 2022

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Oct 12, 2022 •
edited

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

The ProcessArgs is missing OplogMinRetentionHours property. See Update Advanced Configuration Options for One Cluster

@andreaangiolillo andreaangiolillo requested a review from a team as a code owner October 12, 2022 10:02
@andreaangiolillo andreaangiolillo requested review from blva and removed request for a team and blva October 12, 2022 10:02
@andreaangiolillo andreaangiolillo changed the title Cloudp 139997: added OplogMinRetentionHours to ProcessArgs CLOUDP-139997: added OplogMinRetentionHours to ProcessArgs Oct 12, 2022
gssbzn
gssbzn approved these changes Oct 12, 2022
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo merged commit 3b4166c into master Oct 12, 2022
@andreaangiolillo andreaangiolillo mentioned this pull request Oct 12, 2022
Merged
6 tasks
@wtrocki wtrocki deleted the CLOUDP-139997 branch January 26, 2023 08:49
@wtrocki wtrocki restored the CLOUDP-139997 branch January 26, 2023 08:49
@wtrocki wtrocki deleted the CLOUDP-139997 branch January 26, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andreaangiolillo @gssbzn