-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INTMDB-454: Add support for root query to get org_id from API Key used in Terraform #333
Conversation
mongodbatlas/root.go
Outdated
/*type Root struct { | ||
Links []*Link `json:"links"` | ||
Results []APIKey `json:"results,omitempty"` | ||
TotalCount int `json:"totalCount"` | ||
}*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/*type Root struct { | |
Links []*Link `json:"links"` | |
Results []APIKey `json:"results,omitempty"` | |
TotalCount int `json:"totalCount"` | |
}*/ |
if not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed commented code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if you manually tested this since it seems to be different from the public docs so assuming is a mistake on docs and not on code
@gssbzn if the docs don't include I'd like to get them corrected. Did you check old and new docs? I can point a docs ticket to this PR to get it fixed if needed. |
Yes legacy Docs are incorrect for returned json value for GET ... I am using this code for TF resource working fine |
@martinstibbe and are the new docs correct https://www.mongodb.com/docs/atlas/reference/api-resources-spec/#tag/Root/operation/getSystemStatus? |
could we link to the new docs instead if they are correct? |
Yes these are accurate I will change link(s) in code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for the update on links
Description
INTMDB-454: Add support for root query to get org_id from API Key used in Terraform
Link to any related issue(s):
Type of change:
Required Checklist:
make fmt
and formatted my codeFurther comments