Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTMDB-454: Add support for root query to get org_id from API Key used in Terraform #333

Merged
merged 7 commits into from
Dec 16, 2022

Conversation

martinstibbe
Copy link
Collaborator

@martinstibbe martinstibbe commented Dec 16, 2022

Description

INTMDB-454: Add support for root query to get org_id from API Key used in Terraform

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@martinstibbe martinstibbe requested a review from a team as a code owner December 16, 2022 04:36
Comment on lines 36 to 40
/*type Root struct {
Links []*Link `json:"links"`
Results []APIKey `json:"results,omitempty"`
TotalCount int `json:"totalCount"`
}*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/*type Root struct {
Links []*Link `json:"links"`
Results []APIKey `json:"results,omitempty"`
TotalCount int `json:"totalCount"`
}*/

if not needed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed commented code

gssbzn
gssbzn previously approved these changes Dec 16, 2022
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you manually tested this since it seems to be different from the public docs so assuming is a mistake on docs and not on code

@themantissa
Copy link
Collaborator

@gssbzn if the docs don't include I'd like to get them corrected. Did you check old and new docs? I can point a docs ticket to this PR to get it fixed if needed.

@martinstibbe
Copy link
Collaborator Author

LGTM if you manually tested this since it seems to be different from the public docs so assuming is a mistake on docs and not on code

Yes legacy Docs are incorrect for returned json value for GET ... I am using this code for TF resource working fine

@gssbzn
Copy link
Collaborator

gssbzn commented Dec 16, 2022

@gssbzn
Copy link
Collaborator

gssbzn commented Dec 16, 2022

could we link to the new docs instead if they are correct?

@martinstibbe
Copy link
Collaborator Author

@martinstibbe and are the new docs correct https://www.mongodb.com/docs/atlas/reference/api-resources-spec/#tag/Root/operation/getSystemStatus?

Yes these are accurate I will change link(s) in code

Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the update on links

@martinstibbe martinstibbe merged commit 08be1f5 into master Dec 16, 2022
@martinstibbe martinstibbe deleted the INTMDB-454 branch December 16, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants