Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: use new setup go features on github actions #186

Merged
merged 3 commits into from
Mar 21, 2023

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Mar 21, 2023

Proposed changes

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

Use the new features of set up go for stable and oldstable versions and auto use of cache

@gssbzn gssbzn requested a review from a team as a code owner March 21, 2023 15:06
@wtrocki
Copy link
Member

wtrocki commented Mar 21, 2023

I do see the cache being removed. Happy to port the same to the go-client repository as well

@gssbzn
Copy link
Collaborator Author

gssbzn commented Mar 21, 2023

Happy to port the same to the go-client repository as well

I think dependabot hasn't run there yet so waiting on that, alsoI think golangci-lint is having some issues with this change

@wtrocki
Copy link
Member

wtrocki commented Mar 21, 2023

I think you know it but mentioning it: There is this funny problem with updating go version and golang ci lint that many errors started to appear. This is because that versions > 1.18 have much better ast inspection capabilities so golangci lint can go deeper and inspect multi file relationships :)

@gssbzn gssbzn merged commit 994e856 into master Mar 21, 2023
@gssbzn gssbzn deleted the setup-go-new-features branch March 21, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants