Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check both window and self #423

Merged
merged 1 commit into from
Mar 2, 2021
Merged

check both window and self #423

merged 1 commit into from
Mar 2, 2021

Conversation

fasidOnGit
Copy link
Contributor

@fasidOnGit fasidOnGit commented Feb 4, 2021 •
edited

Description

This PR makes this package usable in a web-worker.

Another approach would be to use globalThis. But, that would required node 12+, I see there is quite good support for it in browsers.

nbbeeken
nbbeeken approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this fix, LGTM we'll get this out in the next release.

@durran durran merged commit 5ae057d into mongodb:master Mar 2, 2021
@dependabot dependabot bot mentioned this pull request Mar 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@durran durran Awaiting requested review from durran

@emadum emadum Awaiting requested review from emadum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@fasidOnGit @nbbeeken @durran