docs(NODE-4349): add note about Binary(string) behavior #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
commented
Jun 28, 2022
10 tasks
durran
added
the
Primary Review
durran
approved these changes
Jun 28, 2022
durran
added
Team Review
nbbeeken
approved these changes
Jun 29, 2022
nbbeeken
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Adds a note that Binary(string) is probably not what you want unless you really know what you’re doing.
(This was inspired by old Compass code getting this wrong in at least one place.)
Is there new documentation needed for these changes?
This is a doc change.
What is the motivation for this change?
Double check the following
npm run lintscript<type>(NODE-xxxx)<!>: <description>