Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(NODE-5080): add a note about class syntax #565

Merged
merged 2 commits into from Mar 2, 2023
Merged

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

Mention the class syntax "new" requirement

What is the motivation for this change?

Clarity on a v5 breaking change

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken requested a review from dariakp March 2, 2023 18:06
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 2, 2023
docs/upgrade-to-v5.md Outdated Show resolved Hide resolved
Co-authored-by: Daria Pardue <daria.pardue@mongodb.com>
@nbbeeken nbbeeken requested a review from dariakp March 2, 2023 22:00
@dariakp dariakp merged commit 800f7cd into main Mar 2, 2023
@dariakp dariakp deleted the NODE-5080-class-syntax branch March 2, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
2 participants