fix(NODE-5586): Decimal128 fromString performs inexact rounding #620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Decimal128.fromString
algorithm to match that in mongo-c-driverDecimal128
spec testsDecimal128
spec testsIs there new documentation needed for these changes?
What is the motivation for this change?
NODE-5586
Release Highlight
Decimal128
constructor now throws when detecting loss of precisionPrior to this release,
Decimal128
would round numbers with more than 34 significant digits and lose precision. Now, on detecting loss of precision,Decimal128
's constructor andDecimal128.fromString
will throw aBSONError
. This behaviour should have been the default as theDecimal128
class was always intended to be high-precision floating point value. As such, silently rounding is undesirable behaviour.Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript