Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NODE-5547): fix npm version setting var #633

Merged
merged 1 commit into from
Sep 28, 2023
Merged

chore(NODE-5547): fix npm version setting var #633

merged 1 commit into from
Sep 28, 2023

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Sep 27, 2023 •
edited by durran
Loading

Description

What is changing?

Move the NPM_VERSION var to the install dependencies task

Is there new documentation needed for these changes?

No.

What is the motivation for this change?

Make sure node 14 installs the right version of npm

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran self-assigned this Sep 28, 2023
@durran durran added the Team Review Needs review from team label Sep 28, 2023
@durran durran merged commit 4d5487d into 5.x Sep 28, 2023
3 checks passed
@durran durran deleted the NODE-5547-fix-BSON-ci branch September 28, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

Assignees

@durran durran

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
2 participants
@nbbeeken @durran