Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-5958): add BSON iterating API #656

Merged
merged 8 commits into from Mar 15, 2024
Merged

feat(NODE-5958): add BSON iterating API #656

merged 8 commits into from Mar 15, 2024

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Mar 8, 2024 •
edited

Description

What is changing?

  • Added an API that will iterate embedded document structures in BSON
Is there new documentation needed for these changes?

No.

What is the motivation for this change?

To encapsulate the complexity of iterating into nested structures such that one can write a function responsible for reviving each BSON value as needed and decide whether or not to create a nested structure.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review March 11, 2024 17:57
aditi-khare-mongoDB
aditi-khare-mongoDB requested changes Mar 11, 2024
View reviewed changes
src/parser/on_demand/parse_to_elements.ts Outdated Show resolved Hide resolved
test/node/tools/utils.js Show resolved Hide resolved
test/node/parser/on_demand/parse_to_structure.test.ts Outdated Show resolved Hide resolved
src/parser/on_demand/parse_to_structure.ts Outdated Show resolved Hide resolved
src/parser/on_demand/parse_to_structure.ts Outdated Show resolved Hide resolved
src/parser/on_demand/parse_to_structure.ts Outdated Show resolved Hide resolved
@aditi-khare-mongoDB aditi-khare-mongoDB added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 11, 2024
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Mar 13, 2024
baileympearson
baileympearson requested changes Mar 13, 2024
View reviewed changes
src/parser/on_demand/parse_to_elements.ts Outdated Show resolved Hide resolved
src/parser/on_demand/parse_to_structure.ts Show resolved Hide resolved
src/parser/on_demand/parse_to_structure.ts Show resolved Hide resolved
src/parser/on_demand/parse_to_structure.ts Outdated Show resolved Hide resolved
src/parser/on_demand/parse_to_structure.ts Outdated Show resolved Hide resolved
@aditi-khare-mongoDB aditi-khare-mongoDB merged commit 269df91 into main Mar 15, 2024
5 checks passed
@aditi-khare-mongoDB aditi-khare-mongoDB deleted the NODE-5958-parseToStructure branch March 15, 2024 17:54
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
Merged
@github-actions github-actions bot mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

@W-A-James W-A-James W-A-James approved these changes

@aditi-khare-mongoDB aditi-khare-mongoDB aditi-khare-mongoDB approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
4 participants
@nbbeeken @baileympearson @W-A-James @aditi-khare-mongoDB