PHPORM-119 Fix integration with Spatie Query Builder - Don't qualify field names in document models #2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
approved these changes
Nov 13, 2023
GromNaN
changed the title
4 tasks
jmikola
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2409 PHPORM-119
As far as I know, there are no cases where you would want to prefix the field name with the collection name. Except in
$lookupaggregation pipeline, but that's out of scope of the query builder.Note that I'm adding the package
spatie/laravel-query-builderas a dev dependency to ensure we will always support it. It's a very popular package that looks stable.