Fix casting issues (issue: #2703) #2705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will not change how it functions, just makes it simpler
|
I will update the changelog and see if there's any documentation to update later today |
GromNaN
reviewed
Jan 10, 2024
There was a problem hiding this comment.
Hello @stubbo, thanks for investigating the issue and submitting a patch.
@hans-thomas you may be interested in reviewing this PR as you worked on this part previously.
| try { | ||
| $value = (string) BigDecimal::of((string) $value)->toScale((int) $decimals, RoundingMode::HALF_UP); | ||
|
|
||
| return new Decimal128($value); |
There was a problem hiding this comment.
👍 Good catch, the method asDecimal must return a string, as mandated in the phpdoc of the parent method.
Co-authored-by: Jérôme Tamarelle <jerome@tamarelle.net>
Co-authored-by: Jérôme Tamarelle <jerome@tamarelle.net>
niyazialpay
approved these changes
Jan 10, 2024
stubbo
commented
Jan 11, 2024
GromNaN
approved these changes
Jan 16, 2024
|
@GromNaN Do you want me to update the change log? |
|
Hi @GromNaN, I will be unavailable for next month too. sorry. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#2653 Added a cast inside of the setAttribute, intended to be used when accessing raw data from a model, not adding data.
This will cause some casts to break fully. If you have the encrypt cast it will try to decrypt a string before encrypting it which causes an exception.
I have explained this in more detail in issue #2703
Checklist