New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDRIVER-2902: bitFlags field for OP_MSG does not swap for Big-Endian zSeries system #557

Closed
wants to merge 1 commit into
base: r1.13
from

Conversation

Projects
None yet
2 participants
@derickr
Copy link
Member

derickr commented Dec 19, 2018

https://jira.mongodb.org/browse/CDRIVER-2902

Sorry it's on the wrong branch, but this was made from a checkout on zSeries with little tools available.

@derickr derickr requested a review from kevinAlbs Dec 19, 2018

@kevinAlbs

This comment has been minimized.

Copy link
Collaborator

kevinAlbs commented Dec 20, 2018

LGTM, can you just update the commit message? This isn't specific to zSeries, but big-endian in general. Also, we try to conform to the 50/72 commit message rule (I'll note that in CONTRIBUTING.md...).

Maybe something like:
"CDRIVER-2902: fix OP_MSG bitFlags for Big-Endian"

@derickr derickr force-pushed the derickr:bitFlags-swap branch from 714c9c2 to b2937ab Dec 20, 2018

@derickr

This comment has been minimized.

Copy link
Member

derickr commented Dec 20, 2018

I've updated the commit message. I'll leave it to you to cherry-pick it onto the right branch(es)

@kevinAlbs

This comment has been minimized.

Copy link
Collaborator

kevinAlbs commented Dec 20, 2018

This has been cherry-picked. Closing.

@kevinAlbs kevinAlbs closed this Dec 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment