CDRIVER-2902: bitFlags field for OP_MSG does not swap for Big-Endian zSeries system #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, can you just update the commit message? This isn't specific to zSeries, but big-endian in general. Also, we try to conform to the 50/72 commit message rule (I'll note that in CONTRIBUTING.md...). Maybe something like: |
derickr
force-pushed
the
bitFlags-swap
branch
from
714c9c2
to
b2937ab
Compare
|
I've updated the commit message. I'll leave it to you to cherry-pick it onto the right branch(es) |
|
This has been cherry-picked. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/CDRIVER-2902
Sorry it's on the wrong branch, but this was made from a checkout on zSeries with little tools available.