VS-77: Add more enum test cases #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved tests for Nullable Enums Added more Enumerator Arithmetic Operation Test Cases Added Test Cases for Unsupported Enum Operations
BorisDog
requested changes
Jun 28, 2023
| .Where(u => u.Vehicle.VehicleType.Type == vehicleType) | ||
| .Select(u => u.Vehicle.LicenceNumber); | ||
|
|
||
| VehicleTypeEnum? nullibleVehicleType = VehicleTypeEnum.Bus; |
|
|
||
| _ = GetMongoQueryable<Person>() | ||
| .Where(u => u.Vehicle.VehicleType.Type == nullibleVehicleType) | ||
| .Select(u => u.Vehicle.LicenceNumber); |
There was a problem hiding this comment.
This should work in linq. So we need to generate mql.
There was a problem hiding this comment.
Created another ticket for Nullable support(i.e. VS-93) will implement changes in that ticket
| var secondVehicleType = VehicleTypeEnum.Motorcylce; | ||
|
|
||
| _ = GetMongoQueryable<EnumHolder>() | ||
| .Where(u => u.EnumUInt64 == firstUnsignedEnum || u.EnumUInt64 == secondUnsignedEnum || u.EnumUInt64 == thirdUnsignedEnum) |
There was a problem hiding this comment.
I suggest modifying the test to test all enum types (byte, short, etc) once in single statement.
| @@ -130,5 +130,15 @@ public void Query_syntax() | |||
| where ReturnArgument(ReturnArgument(ReturnArgument(this).ReturnArgument(person.Vehicle.VehicleType))).Type == VehicleTypeEnum.Bus | |||
| select person; | |||
| } | |||
|
|
|||
| [InvalidLinq("Convert(Convert((Convert({document}{EnumInt16}, Int32) + 10), GenType_Enum_12), Int32) is not supported.")] | |||
| [InvalidLinq3("Cannot find serializer for Convert(u.EnumInt16, Int32).", version: "[2.14.0-beta1, 2.18.0)")] | |||
There was a problem hiding this comment.
Let's have constants for versions (DriverVersions)
| .Where(u => u.EnumInt64 == EnumInt64.Value0 + 35); | ||
|
|
||
| _ = GetMongoQueryable<EnumHolder>() | ||
| .Where(u => u.EnumInt64 == EnumInt64.Value0 - 35); |
BorisDog
requested changes
Jul 14, 2023
| @@ -21,7 +21,13 @@ public static class DriverVersions | |||
| public const string Linq3NonDefault = "[2.14.0-beta1, 2.19.0)"; | |||
| public const string Linq3DefaultAndHigher = V2_19_AndHigher; | |||
| public const string Linq2DefaultAndLower = V2_18_AndLower; | |||
|
|
|||
| public const string V2_14_Beta1_Till_V2_18 = "[2.14.0-beta1, 2.18.0)"; | |||
| _ = GetMongoQueryable<EnumHolder>() | ||
| .Where(u => u.EnumInt32 == EnumInt32.Value0 - 25); | ||
|
|
||
| _ = GetMongoQueryable<EnumHolder>() |
There was a problem hiding this comment.
What about left-hand operations: .Where(u => u.EnumInt32 + 123 == EnumInt32.Value0 - 25)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more Enum Test Cases for LINQ covering situations where the Enum is in a variable and that variable is referenced in the query(i.e. either query syntax or the method invocation syntax).