Better support for dates and strings in LINQ #253
Conversation
1) Overload for Substring() with single arg now works 2) Overload for Equals() with single arg now works 3) Also added static version of String.Equals() 4) Added some of the overloads for String.Concat() 5) More checks for correct number of arguments
1) Added DateTime.ToString() (via $dateToString) 2) Added support of AddDays(), AddHours(), AddMinutes(), AddSeconds() and AddMilliseconds() operations AddYears() and AddMonths() are currently not implemented to not overcomplicate requests, while Add() and Subtract() are not implemented because TimeSpan is not convertible to BsonValue
|
Hi @pieceofsummer, Thanks so much for the PR. Couple things I noticed.
If you could do both those things, we'll look at pulling this in. |
|
Hi @craiggwilson,
There's also that recent issue with .NET Core when connecting to DNS endpoints on Unix, which makes even existing tests to fail for me… :( |
|
@craiggwilson, I'm also a bit confused with the current implementation of math functions. Docs say almost all math functions (except $pow and $log, for obvious reasons) take just a single number, but the driver gives them an array (with single number inside). Furthermore, Mongo server accepts both dialects, while being rather strict about other functions' arguments. Can you please clarify this a little? |
|
Formally, the server wants an array as the argument. For single-valued args, they accept just a value without being in an array. I forgot what we currently do, but might as well follow whatever pattern we are currently using. |
|
Added some unit tests, hope it's ok now :) |
|
This is awesome. We'll discuss and see if there is anything left to do. Might ask you to squash and rebase on master just before the pull to ensure you get credit properly. Will let you know. |
|
Should I rebase or close this? I kinda see |
|
I have made an updated version of this PR: #351 which is based off current master. |
|
Closing as superseded by #351 |
While playing around with some custom serializers and complex classes, I've found a few errors and a bunch of not implemented functions, so I spent an evening trying to make the world a better place :)
Hope it will be helpful.