CSHARP-2445 Improve supported methods of DateTime in LINQ #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Overload for Substring() with single arg now works 2) Overload for Equals() with single arg now works 3) Also added static version of String.Equals() 4) Added some of the overloads for String.Concat() 5) More checks for correct number of arguments
1) Added DateTime.ToString() (via $dateToString) 2) Added support of AddDays(), AddHours(), AddMinutes(), AddSeconds() and AddMilliseconds() operations AddYears() and AddMonths() are currently not implemented to not overcomplicate requests, while Add() and Subtract() are not implemented because TimeSpan is not convertible to BsonValue
…csharp-driver into better-linq # Conflicts: # src/MongoDB.Driver/Linq/Translators/AggregateLanguageTranslator.cs
Remove IFormat support from DateTime.ToString() Minor code cleanup
elliott-pd
changed the title
Remove unused imports Update README
Contributor
|
Thank you for submitting this PR and our apologies that it took so long to look at it. I am closing this PR as support for DateTime methods like AddDays etc... is already part of the LINQ3 provider. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the PR put forward by @pieceofsummer: #253.
It is on the current master, with all tests passing. There has been a minor code cleanup and a few fixes for tests.