GODRIVER-2492 use consistent versions of crypt_shared and server #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this matches behavior of run-orchestration.sh
get_distro uses . /etc/os-release On some hosts, that overwrites the VERSION environment variable.
This reverts commit 2810078.
kevinAlbs
changed the title
matthewdale
approved these changes
Jul 19, 2022
| . $DRIVERS_TOOLS/.evergreen/download-mongodb.sh | ||
| get_distro | ||
| get_mongodb_download_url_for "$DISTRO" "$MONGODB_VERSION" | ||
| if [ -z "$MONGO_CRYPT_SHARED_DOWNLOAD_URL" ]; then |
There was a problem hiding this comment.
Optional: Add a note about where $MONGO_CRYPT_SHARED_DOWNLOAD_URL and $EXTRACT come from. I had to do some searching to figure out that get_mongodb_download_url_for sets those env vars.
There was a problem hiding this comment.
Good thinking. Done.
| echo "Downloading crypt_shared package from $MONGO_CRYPT_SHARED_DOWNLOAD_URL" | ||
| download_and_extract_crypt_shared "$MONGO_CRYPT_SHARED_DOWNLOAD_URL" "$EXTRACT" | ||
| touch expansion.yml | ||
| fi |
There was a problem hiding this comment.
Nice find with expansions.update! Should we move the find command from run-tests.sh here and add CRYPT_SHARED_LIB_PATH to the expansions instead of setting SKIP_CRYPT_SHARED_LIB_DOWNLOAD if we didn't download it?
There was a problem hiding this comment.
Good idea. I have updated to move the find command here and set a CRYPT_SHARED_LIB_PATH expansion.
The expansion is set on the task function, not the variant.
This reverts commit 4e445a6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Background & Motivation
This PR validates changes proposed in mongodb-labs/drivers-evergreen-tools#213.
Queryable Encryption is in Technical Preview and is subject to backwards breaking changes. If backwards breaking changes are made, using different version of the server and crypt_shared may complicate diagnosing driver test failures.