Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-2355 add crypt_shared download function to download-mongodb.sh #213

Merged
merged 3 commits into from
Jul 14, 2022

Conversation

kevinAlbs
Copy link
Contributor

@kevinAlbs kevinAlbs commented Jul 13, 2022

Summary

  • Do not set MONGO_CRYPT_SHARED_DOWNLOAD_URL for versions < 6.0.
  • Add download_and_extract_crypt_shared.

Background & Motivation

This intends to simplify using the same version of crypt_shared as the server for driver testing.
Queryable Encryption is still in Technical Preview and is subject to backwards breaking changes.
If backwards breaking changes are made, using different version of the server and crypt_shared may complicate diagnosing driver test failures.

Here is a POC of porting the Go driver scripts. This is the usage of the download_and_extract_crypt_shared:

. $DRIVERS_TOOLS/.evergreen/download-mongodb.sh
get_distro
get_mongodb_download_url_for "$DISTRO" "${VERSION}"
if [ -z "$MONGO_CRYPT_SHARED_DOWNLOAD_URL" ]; then
    echo "There is no crypt_shared library for distro='$DISTRO' and version='${VERSION}'".
    echo "SKIP_CRYPT_SHARED_LIB_DOWNLOAD: true" > expansion.yml
else
    echo "Downloading crypt_shared package from $MONGO_CRYPT_SHARED_DOWNLOAD_URL"
    download_and_extract_crypt_shared "$MONGO_CRYPT_SHARED_DOWNLOAD_URL" "$EXTRACT"
    touch expansion.yml
fi

current RAPID does not include crypt_shared
Copy link

@DmitryLukyanov DmitryLukyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinAlbs kevinAlbs merged commit 005c9d6 into mongodb-labs:master Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants