Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-2315 Update tests that expect errors with capped collection deletes #854

Merged
merged 3 commits into from Feb 22, 2022
Merged

GODRIVER-2315 Update tests that expect errors with capped collection deletes #854

merged 3 commits into from Feb 22, 2022

Conversation

benjirewis
Copy link
Contributor

@benjirewis benjirewis commented Feb 17, 2022

GODRIVER-2315

SERVER-63201 recently allowed deletes on capped collections in the latest server versions (5.3). Some of our tests in integration/collection_test.go expect server-side write errors when running a delete operation against a capped collection. Updates these tests to only run against 5.2-.

@benjirewis benjirewis marked this pull request as ready for review February 17, 2022 17:09
@benjirewis
Copy link
Contributor Author

Further work to add support for these tests on 5.3+ will be done as part of GODRIVER-2320.

Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@benjirewis benjirewis merged commit 723f7d7 into mongodb:master Feb 22, 2022
@benjirewis benjirewis deleted the cappedCollectionDeletes.2315 branch February 22, 2022 19:29
faem pushed a commit to kubedb/mongo-go-driver that referenced this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants