New signature for MongoConfigUtil.setOutputURI() that takes MongoClientURI #103
Conversation
|
This is great. A slight oversight. Thanks for cleaning that up. If you mark the other as deprecated, I can merge this today. |
|
Updated. On an unrelated note I looked at the findbugs report (core/build/reports/findbugs/main.html) and it showed zero errors and zero warnings. I don't know why gradlew check failed. Does gradlew check usually work? |
|
It does. I'm not sure what's up there, but I'll check locally and see if I On Wed, Apr 30, 2014 at 12:54 PM, Joseph Shraibman <notifications@github.com
|
New signature for MongoConfigUtil.setOutputURI() that takes MongoClientURI
|
Running with --debug produces: |
|
Are you running with java 8? On Wed, Apr 30, 2014 at 1:01 PM, Joseph Shraibman
|
|
Yes |
|
Ah, yes. The asm lib findbugs uses doesn't support the java 8 class files On Wed, Apr 30, 2014 at 1:04 PM, Joseph Shraibman
|
setInputURI()has a signature that takes aMongoClientURI, butsetOutputURI()only has a signature that takes the deprecatedMongoURI. This PR fixes that.NOTE the
setInputURI()signature that takesMongoURIis marked as deprecated. Should I also deprecate the correspondingsetOutputURI()signature?Test results
Tests fail for me on master, so the fact that they fail on this branch doesn't mean anything. This change seems unlikely to break anything.
[jks@jks-desktop master /mnt/space/home/jks/work/mongo/mongo-hadoop]{f20}$ ./gradlew check
Building against hadoop 2.4 using 2.4.0 libraries
Checking if /home/jks/hadoop-binaries/hadoop-2.4.0/bin exists
:compileJava UP-TO-DATE
:processResources UP-TO-DATE
:classes UP-TO-DATE
:compileTestJava UP-TO-DATE
:processTestResources UP-TO-DATE
:testClasses UP-TO-DATE
:test UP-TO-DATE
:check UP-TO-DATE
:core:compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:core:processResources UP-TO-DATE
:core:classes
:core:checkstyleMain
:core:compileTestJava
:core:processTestResources UP-TO-DATE
:core:testClasses
:core:checkstyleTest UP-TO-DATE
:core:findbugsMain FAILED
FAILURE: Build failed with an exception.
What went wrong:
Execution failed for task ':core:findbugsMain'.
Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 26.831 secs