Improve performance of MongoNamespace.checkDatabaseNameValidity

JAVA-3619
mongodb · Feb 21, 2020 · 0c00878 · 0c00878
1 parent df7cf82
commit 0c00878
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/driver-core/src/main/com/mongodb/MongoNamespace.java b/driver-core/src/main/com/mongodb/MongoNamespace.java
@@ -58,8 +58,9 @@ public static void checkDatabaseNameValidity(final String databaseName) {
         notNull("databaseName", databaseName);
         isTrueArgument("databaseName is not empty", !databaseName.isEmpty());
         for (int i = 0; i < databaseName.length(); i++) {
-            isTrueArgument("databaseName does not contain '" + databaseName.charAt(i) + "'",
-                    !PROHIBITED_CHARACTERS_IN_DATABASE_NAME.contains(databaseName.charAt(i)));
+            if (PROHIBITED_CHARACTERS_IN_DATABASE_NAME.contains(databaseName.charAt(i))) {
+                throw new IllegalArgumentException("state should be: databaseName does not contain '" + databaseName.charAt(i) + "'");
+            }
         }
     }