Revert DBCollection.find requring notNull queries

Historically it has, so changing it breaks existing behaviour. JAVA-2322
mongodb · Sep 26, 2016 · c5fe552 · c5fe552
1 parent 28eb7cc
commit c5fe552
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/driver/src/main/com/mongodb/DBCursor.java b/driver/src/main/com/mongodb/DBCursor.java
@@ -103,7 +103,7 @@ public DBCursor(final DBCollection collection, final DBObject query, final DBObj
     private DBCursor(final DBCollection collection, final DBObject filter, final DBCollectionFindOptions findOptions,
                      final OperationExecutor executor, final DBDecoderFactory decoderFactory, final Decoder<DBObject> decoder) {
         this.collection = notNull("collection", collection);
-        this.filter = notNull("filter", filter);
+        this.filter = filter;
         this.executor = notNull("executor", executor);
         this.findOptions = notNull("findOptions", findOptions.copy());
         this.decoderFactory = decoderFactory;

diff --git a/driver/src/test/functional/com/mongodb/DBCollectionTest.java b/driver/src/test/functional/com/mongodb/DBCollectionTest.java
@@ -123,6 +123,12 @@ public void testInsert() {
         assertEquals(new BasicDBObject("_id", 1).append("x", 2), collection.findOne());
     }
 
+    @Test
+    public void testFindWithNullQuery() {
+        collection.insert(new BasicDBObject("_id", 1).append("x", 2));
+        assertEquals(new BasicDBObject("_id", 1).append("x", 2), collection.find(null).next());
+    }
+
     @Test
     public void testInsertDuplicateKeyException() {
         DBObject doc = new BasicDBObject("_id", 1);