Add AsyncOperations to match SyncOperations #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyemin
commented
Oct 28, 2022
| /** | ||
| * <p>This class is not part of the public API and may be removed or changed at any time</p> | ||
| */ | ||
| public final class AsyncOperations<TDocument> { |
There was a problem hiding this comment.
Copied from SyncOperations and just changed the interface types to be the Async equivalents
| @@ -74,7 +74,7 @@ | |||
| import static java.util.Collections.singletonList; | |||
| import static java.util.concurrent.TimeUnit.MILLISECONDS; | |||
|
|
|||
| public final class Operations<TDocument> { | |||
| final class Operations<TDocument> { | |||
There was a problem hiding this comment.
This can now be package private
| @@ -171,8 +170,6 @@ private static Object checkValueTypes(final Object instance) { | |||
| Object actual = instance instanceof Optional ? ((Optional<Object>) instance).orElse(instance) : instance; | |||
| if (actual instanceof AsyncReadOperation || actual instanceof AsyncWriteOperation) { | |||
| return getClassPrivateFieldValues(actual); | |||
| } else if (actual instanceof Operations) { | |||
There was a problem hiding this comment.
I put a break point here and the branch was never entered, so I just removed it
stIncMale
approved these changes
Oct 28, 2022
ispringer
pushed a commit
to evergage/mongo-java-driver
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-4795
One more change to clean up use of internal
operationpackageThe benefit is that, like with
SyncOperation,AsyncOperationsdoesn't expose the concrete class of any operation, and just deals with the interfaces likeAsyncReadOperationandAsyncWriteOperation.This gets us closer to a state where we can make all concrete Operation classes package private. The main thing stopping us from doing it now is that driver-legacy was never refactored to use SyncOperations and still constructs each operation directly.