Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSGi package imports for AWS SDK v1 and v2 #1065

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Conversation

jyemin
Copy link
Contributor

@jyemin jyemin commented Jan 10, 2023

JAVA-4836

One thing that's weird here is that there is no version range in the jar file:

Import-Package: io.netty.bootstrap;resolution:=optional;version="[4.1,
 5)",io.netty.buffer;resolution:=optional;version="[4.1,5)",io.netty.c
 hannel;resolution:=optional;version="[4.1,5)",io.netty.channel.nio;re
 solution:=optional;version="[4.1,5)",io.netty.channel.socket;resoluti
 on:=optional;version="[4.1,5)",io.netty.channel.socket.nio;resolution
 :=optional;version="[4.1,5)",io.netty.handler.ssl;resolution:=optiona
 l;version="[4.1,5)",io.netty.handler.timeout;resolution:=optional;ver
 sion="[4.1,5)",io.netty.util.concurrent;resolution:=optional;version=
 "[4.1,5)",com.amazonaws.auth;resolution:=optional,software.amazon.aws
 sdk.auth.credentials;resolution:=optional,org.xerial.snappy;resolutio
 n:=optional;version="[1.1,2)",com.github.luben.zstd;resolution:=optio
 nal;version="[1.5,2)",org.slf4j;resolution:=optional;version="[1.7,2)
 ",jnr.unixsocket;resolution:=optional;version="[0.38,1)",com.mongodb.
 crypt.capi;resolution:=optional;version="[1.6,2)",jdk.net;resolution:
 =optional,org.bson.codecs.record;resolution:=optional;version="[4.9,5
 )",javax.crypto,javax.crypto.spec,javax.management,javax.naming,javax
 .naming.directory,javax.net,javax.net.ssl,javax.security.auth,javax.s
 ecurity.auth.callback,javax.security.auth.kerberos,javax.security.aut
 h.login,javax.security.sasl,org.bson;version="[4.9,5)",org.bson.asser
 tions;version="[4.9,5)",org.bson.codecs;version="[4.9,5)",org.bson.co
 decs.configuration;version="[4.9,5)",org.bson.codecs.jsr310;version="
 [4.9,5)",org.bson.codecs.pojo;version="[4.9,5)",org.bson.codecs.pojo.
 annotations;version="[4.9,5)",org.bson.conversions;version="[4.9,5)",
 org.bson.io;version="[4.9,5)",org.bson.json;version="[4.9,5)",org.bso
 n.types;version="[4.9,5)",org.ietf.jgss

I don't know what control this behavior, and not clear why there is no version for software.amazon.aws sdk.auth.credentials or software.amazon.aws.sdk.auth.credentials or what the affect of that might be. I will post a question about it in the ticket.

@jyemin jyemin requested a review from rozza January 10, 2023 22:56
@rozza
Copy link
Member

rozza commented Jan 11, 2023

I have no idea as to why some packages include a version and others don't but it appears testing shows it works. 🤷

Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyemin jyemin merged commit f0e400b into mongodb:master Jan 11, 2023
@jyemin jyemin deleted the j4836 branch January 11, 2023 17:05
ispringer pushed a commit to evergage/mongo-java-driver that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants