Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added range index support for queryable encryption #1069

Merged
merged 6 commits into from
Feb 1, 2023

Conversation

rozza
Copy link
Member

@rozza rozza commented Jan 20, 2023

Note: The Range algorithm is experimental only.
It is not intended for public use.
It is subject to breaking changes.

JAVA-4625

@rozza rozza marked this pull request as draft January 20, 2023 17:28
Note: The Range algorithm is experimental only.
      It is not intended for public use.
      It is subject to breaking changes.

JAVA-4625
@rozza rozza marked this pull request as ready for review January 26, 2023 16:13
@rozza
Copy link
Member Author

rozza commented Jan 26, 2023

I'll review the build errors once the version is fixed.

@rozza rozza requested a review from jyemin January 26, 2023 16:14
build.gradle Outdated
// includeGroup "org.mongodb"
// }
// }
maven {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a temp change. Will revert once libmongocrypt 1.7.0 binding have been pushed.

* @see <a href="https://code-case.hashnode.dev/how-to-pass-parameterized-test-parameters-to-beforeeachaftereach-method-in-junit5">AfterBeforeParameterResolver</a>
* @see <a href="https://github.com/junit-team/junit5/issues/944">junit-team/junit5#944</a>
*/
public class AfterBeforeParameterResolver implements BeforeEachMethodAdapter, ParameterResolver {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite fun for parameterized tests that require the parameters in the before / after methods.

protected abstract ClientEncryption createClientEncryption(ClientEncryptionSettings settings);

@BeforeEach
public void setUp(final Type type) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AfterBeforeParameterResolver provides the type to the setup method!

}

@ParameterizedTest(name = "[{0}] Case 1: can decrypt a payload")
@EnumSource(Type.class)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for each type of Type!

Copy link
Contributor

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't reviewed the tests yet but wanted to provide feedback on the API first.

@rozza rozza requested a review from jyemin January 27, 2023 11:18
@jyemin jyemin requested a review from kevinAlbs January 27, 2023 11:56
Copy link
Contributor

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Added @kevinAlbs to make sure we didn't miss anything.

@jyemin
Copy link
Contributor

jyemin commented Jan 27, 2023

Any idea what's causing the CI failures?

Oh, it's the mongodb-crypt library. I thought it would have been able to grab a snapshot from Sonatype

@rozza rozza requested a review from jyemin January 31, 2023 16:34
@rozza
Copy link
Member Author

rozza commented Jan 31, 2023

Thankfully, the build is much happier - rerunning the one task that failed.

@rozza rozza merged commit e761f17 into mongodb:master Feb 1, 2023
@rozza rozza deleted the JAVA-4625 branch February 1, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants