Ensure BatchCursorFlux does not drop an error #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BatchCursor class can be closed by the BatchCursorFlux class but there is no signalling for the BatchCursor onNext publisher. This leads to a next() called after the cursor was closed error and that breaks the reactive streams spec as the error ends up being dropped. JAVA-4849
This reverts commit 8ffbef4.
jyemin
reviewed
Feb 1, 2023
...ams/src/test/functional/com/mongodb/reactivestreams/client/internal/BatchCursorFluxTest.java
Show resolved
Hide resolved
|
To add some more context - the "error" reported is a logging message similar to:
So the program works as expected it just logs an error as the default The test ensures that after the fix no https://projectreactor.io/docs/core/release/reference/#hooks-dropping |
|
Updated to check the parent sink to see if its been cancelled. This should be a better flag to use here. |
jyemin
reviewed
Feb 1, 2023
driver-reactive-streams/src/main/com/mongodb/reactivestreams/client/internal/BatchCursor.java
Show resolved
Hide resolved
...ams/src/test/functional/com/mongodb/reactivestreams/client/internal/BatchCursorFluxTest.java
Show resolved
Hide resolved
driver-reactive-streams/src/main/com/mongodb/reactivestreams/client/internal/BatchCursor.java
Outdated
Show resolved
Hide resolved
jyemin
reviewed
Feb 2, 2023
driver-reactive-streams/src/main/com/mongodb/reactivestreams/client/internal/BatchCursor.java
Show resolved
Hide resolved
...r-reactive-streams/src/main/com/mongodb/reactivestreams/client/internal/BatchCursorFlux.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BatchCursor class can be closed by the BatchCursorFlux class but there is no signalling for the BatchCursor onNext publisher.
This leads to a next() called after the cursor was closed error and that breaks the reactive streams spec as the error ends up being dropped.
JAVA-4849