Fix documentation of ClientEncryptionSettings#keyVaultMongoClientSett… #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ings property to indicate it can't be null * Update Javadoc * Add notNull assertion in ClientEncryptionSettings constructor * Remove unnecessary null checks and corresponding SpotBugs exclusions for them JAVA-4861
|
Tests were failing. One fix was obvious but the one to the unified tests was less so. And I think the issue there was why the settings were made pseudo-nullable before this patch. It's because the unified tests require that a MongoClient entity be used as the key vault client, which the Java driver does not allow. So a private API was added to allow it and the settings were not required to be non-null to allow the tests to work. I addressed that by just setting the property in the unified tests even though its value is ignored by the private API. |
ispringer
pushed a commit
to evergage/mongo-java-driver
that referenced
this pull request
May 16, 2023
mongodb#1087) * Update Javadoc * Add notNull assertion in ClientEncryptionSettings constructor * Remove unnecessary null checks and corresponding SpotBugs exclusions for them JAVA-4861
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ings property to indicate it can't be null
JAVA-4861