Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operationId to command events #1101

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Conversation

jyemin
Copy link
Contributor

@jyemin jyemin commented Mar 28, 2023

@jyemin jyemin requested a review from katcharov March 28, 2023 19:15
@jyemin jyemin self-assigned this Mar 28, 2023
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this unused file rather than fix it to use the new API.

*/
@Deprecated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of annoying that we have to preserve BC on constructors like this but it's what we do.

Copy link
Contributor

@katcharov katcharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a couple of questions.

@jyemin jyemin merged commit 7bdd1d7 into mongodb:master Mar 30, 2023
@jyemin jyemin deleted the j4907-command-events branch March 30, 2023 00:08
ispringer pushed a commit to evergage/mongo-java-driver that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants