Add operation identifier to retry logs. #1112
Conversation
|
@vbabanin Is the PR a draft because you had been waiting for the tests to pass? |
| ? format("Retrying the operation due to the error \"%s\"; attempt #%d", exception, oneBasedAttempt) | ||
| : format("Retrying the operation '%s' due to the error \"%s\"; attempt #%d", | ||
| commandDescription, exception, oneBasedAttempt)); | ||
| ? format("Retrying the operation due to the error \"%s\"; attempt #%d; operation ID %s", exception, oneBasedAttempt, operationId) |
There was a problem hiding this comment.
Let's make the message a bit more similar in structure/style to what's in https://github.com/mongodb/specifications/blob/master/source/command-logging-and-monitoring/command-logging-and-monitoring.rst#command-started-message. We typically try to use complete sentences, for instance, rather than weird punctuation.
There was a problem hiding this comment.
Thanks for the suggestion, i have made the necessary changes to align with the recommended style.
|
This PR adds logging of the
OperationContextobject to theCommandOperationHelper.logRetryExecute()method. TheOperationContextobject provides context information about the operation being executed, such as the operation id.Logging the
OperationContextobject can be useful for troubleshooting, as it allows us to track the execution of specific operations.JAVA-4939