Allow tls=false override with mongodb+srv protocol #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyemin
commented
Aug 2, 2023
| new ConnectionString('mongodb+srv://test5.test.build.10gen.cc') | true | ||
| new ConnectionString('mongodb+srv://test5.test.build.10gen.cc/?tls=true') | true | ||
| new ConnectionString('mongodb+srv://test5.test.build.10gen.cc/?ssl=true') | true | ||
| new ConnectionString('mongodb+srv://test5.test.build.10gen.cc/?tls=false') | false |
There was a problem hiding this comment.
This is the only one that failed. The others are just to increase test coverage.
| if (isSrvProtocol && !combinedOptionsMaps.containsKey("ssl")) { | ||
| combinedOptionsMaps.put("ssl", singletonList("true")); | ||
| if (isSrvProtocol && !(combinedOptionsMaps.containsKey("tls") || combinedOptionsMaps.containsKey("ssl"))) { | ||
| combinedOptionsMaps.put("tls", singletonList("true")); |
There was a problem hiding this comment.
Switched to the non-deprecated parameter name
rozza
approved these changes
Aug 2, 2023
| if (isSrvProtocol && !combinedOptionsMaps.containsKey("ssl")) { | ||
| combinedOptionsMaps.put("ssl", singletonList("true")); | ||
| if (isSrvProtocol && !(combinedOptionsMaps.containsKey("tls") || combinedOptionsMaps.containsKey("ssl"))) { | ||
| combinedOptionsMaps.put("tls", singletonList("true")); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-4915